Image 01
profile-image

rybec

Rybec Arethdar
FiftyWays

GTK2 Themes by IamJustUs 50 comments

Thanks for the tip. I just put my latest version through lxappearance this way, with no errors reported. (This time around, I had a much better idea of what I was doing.) - Jun 17 2014
FiftyWays

GTK2 Themes by IamJustUs 50 comments

The edge problem in the new version still exists.

Ok, I know I said I would not have time, but... Well, I really wanted it to work. What can I say.

Anyhow, I now have a version (based on the newest update) that looks identical, but the vertical (and probably horizontal, if that even matters) scrollbar hit area extends to the end of the screen in maximized windows.

This time, I added 3 pixels to both sides of the scrollbars images. I removed the trough_border (set it to 0). I increased the slider_width to 22. This fixed the vertical scrollbars without any visual change to them. It did change the horizontal scrollbars and the stepper buttons though. To fix this, I had to add 3 pixels to the top and bottom of the horizontal scrollbars. To fix the stepper arrows, I made a second copy (since I did not want to break their visuals as spinbuttons), and put them in Scrollbars. For those ones, I added 3 pixels to each side of the vertical ones and another 3 to the side the arrow pointed to. I did the same for the horizontal ones, except adding 3 pixels to top and bottom and to the arrow direction. I had to increase the GtkScrollbar::stepper_size to 19 to accomodate this.

Now, when I switch between the original theme and my modified one, I can see no differences at all.

There is one problem I may decide to correct. This exists even in the original theme. On scrollbars, at the end, past the stepper arrows, I can see 3 pixels of the ruler image. Given how the underlying border image has top and bottom borders, I suspect this area should display border lines, instead of the ruler. Since I created a set of stepper arrows specifically for the scrollbars, I am considering filling the 3 blank pixels at the ends with the part of the border image that belongs there. That would fix the problem with almost no hassle.


To the original author: If you want a copy of my fixed version, let me know, and I will find a way to get it to you. I know this may seem like a trivial change, but in trying to fix this border problem (the original one with the hit area that does not extend to the edge of the screen), I have found that a lot of people are bothered by themes with it. It can really break concentration to have to try to move the mouse back only 3 or 4 pixels every time you try to scroll. (See Fitt's Law for more information: http://en.wikipedia.org/wiki/Fitts%27s_law)

(If you do decide you want a copy of my fixed version, let me know if you are interested in having the end borders fixed as I mentioned above. Since it will only take a few minutes, I can do that.) - Jun 17 2014
FiftyWays

GTK2 Themes by IamJustUs 50 comments

My specific changes seem to have some flaws. I compared my changes to the original, and found a few differences. First, the slider bar extends too far to the left (by what looks like 2 pixels). Second, it looks like it is stretching the scrollbar (width-wise), which may account for it being too wide.

As I have no experience making themes (my hack of a fix in this one is my first experience), I do not know how to fix this issue. Sadly I do not have a few more hours to experiment right now. (Since my specific problem is fixed, I will continue using it though.)

I'll take a look at the newest version as soon as I have time. You may have already fixed this issue, and I just do not know about it yet... - Jun 17 2014
FiftyWays

GTK2 Themes by IamJustUs 50 comments

My specific changes seem to have some flaws. I compared my changes to the original, and found a few differences. First, the slider bar extends too far to the left (by what looks like 2 pixels). Second, it looks like it is stretching the scrollbar (width-wise), which may account for it being too wide.

As I have no experience making themes (my hack of a fix in this one is my first experience), I do not know how to fix this issue. Sadly I do not have a few more hours to experiment right now. (Since my specific problem is fixed, I will continue using it though.) - Jun 17 2014
FiftyWays

GTK2 Themes by IamJustUs 50 comments

I fixed it (I was pretty determined to use this awesome theme, so I made it usable).

Here is how I did it:
First, I increased the width of each of the vertical scroll images by 4 pixels, adding transparent area to the right sides (including the grips).

Second, I changed two values in gtkrc. I changed GtkScrollbar::trough_border to 0, and I changed GtkScrollbar::slider_width to 21. Now, I can scroll in a maximized window when the pointer is at the right edge of the screen (and it still looks right too).


I am pretty sure this is how my fix works (this was the intent, anyhow). I expanded the width of the scrollbar images to be wide enough to cover the trough border (with transparency, so the visuals did not change). Then I reduced the actual trough border to 0 (otherwise it would just push the image to the left, leaving an inactive area). Normally, this would just get rid of the right border, putting the slider directly against the edge, but since the slider has transparent pixels on the right, it ended up in its original location. That last part was just telling the GTK engine that I widened the image (for some reason, telling it I added 4 width did not look right, so I tried telling it I added 5 and that fixed it...).

Anyhow, I am now very happy with this totally awesome theme. Thank you.

(Oh, might I suggest that it would be a good idea to mention, in a prominent location, that the pixbuf engine is required, and may need to be installed, to use this theme.) - Jun 17 2014
FiftyWays

GTK2 Themes by IamJustUs 50 comments

Beautiful theme, but unusable, because scrollbar's hit area does not extend to the edge of the window.

(When using Firefox or any other program with scrollbars, where the program is maximized, it is easiest to scroll with the mouse by moving to the right edge of the screen. When the scroll bar hit area ends before the edge of the window, it takes too much extra effort to go back a few pixels to hit the scrollbar.) - Jun 17 2014